This repository has been archived by the owner on Feb 7, 2024. It is now read-only.
simplified Modularization #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epuzanov
changed the title
|
I will hold off on this one for a little while until I get feedback from you on the "monster jar" I showed you how to make. The 2.x development has mostly winded down while we focus on 3.0 development which cleans this up a lot so I don't know how much this will be necessarily going forward. But I do understand that several collaborators will be using 2.7 for the foreseeable future |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplified GSRS modularization by moving some interfaces and abstract classes used by custom exporters, indexers, initializers, processors, validators and IDGenerators from modues/ginas to core project. All custom extensions can be created within a sub-folder under modules folder (o.e. ./modules/extensioins). Custom project can be build between 'ginasEvo' and 'ginas' projects (Build.scala need to be changed).