addressed security issues flagged on GitHub.

2 unit tests failed... but they failed before the code change
ncats · Jan 3, 2024 · 01eab1c · 01eab1c
1 parent 2435862
commit 01eab1c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/pom.xml b/pom.xml
@@ -7,7 +7,7 @@
   <groupId>gov.nih.ncats</groupId>
   <artifactId>molvec</artifactId>
   <packaging>jar</packaging>
-  <version>0.9.9-SNAPSHOT</version>
+  <version>0.9.10-SNAPSHOT</version>
   <name>MolVec</name>
 
 

diff --git a/src/main/java/gov/nih/ncats/molvec/internal/image/Bitmap.java b/src/main/java/gov/nih/ncats/molvec/internal/image/Bitmap.java
@@ -2064,10 +2064,10 @@ void union (short[] eqvtab, short cls1, short cls2) {
 
         if (i != j) {
             if (eqvtab[j] < eqvtab[i]) {
-                eqvtab[j] += eqvtab[i] - 1;
+                eqvtab[j] += eqvtab[i] - (short)1;
                 eqvtab[i] = j;
             } else {
-                eqvtab[i] += eqvtab[j] - 1;
+                eqvtab[i] += eqvtab[j] - (short)1;
                 eqvtab[j] = i;
             }
         }

diff --git a/src/test/java/gov/nih/ncats/molvec/internal/algo/MoleculeTest.java b/src/test/java/gov/nih/ncats/molvec/internal/algo/MoleculeTest.java
@@ -5882,7 +5882,7 @@ public static List<Object[]> data(){
 		list.add(new Object[]{"alphaPro", new TestSpec("moleculeTest/alpha_problem2.png", c->{
             Chemical cReal=ChemicalBuilder.createFromSmiles("C=C(C)C1CCC(C)=CC1").build();
             String keyReal=Inchi.asStdInchi(cReal).getKey();
-            String keyGot=Inchi.asStdInchi(c).getKey();
+		String keyGot=Inchi.asStdInchi(c).getKey();
             assertEquals(keyReal,keyGot);
         } )});