Allow gif and svg to be uploaded #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndianabasi
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Hello @evoactivity. Thank you for the PR. Please take a look at the comments below.
There was a problem hiding this comment.
Since we are now maintaining two set of formats: generally-allowed formats and processable formats, you need to improve the tests to show that the non-processable formats are merely uploaded without formatting.
| ] | ||
|
|
||
| // Formats we want to be safely processed by sharp | ||
| export const conversionFormats: Array<AllowedFormats> = ['jpeg', 'png', 'webp', 'avif', 'tiff'] |
There was a problem hiding this comment.
Rename variable to processableFormats. Also append as const to the array.
You should also exclude the non-processable formats from the assigned type: Array<AllowedFormat>. E.g. Array<Exclude<AllowedFormat, 'gif' | 'svg' | 'svg+xml'>>
| @@ -67,17 +67,26 @@ export const resizeTo = async function ( | |||
| export const breakpointSmallerThan = (breakpoint: number, { width, height }: FileDimensions) => | |||
| breakpoint < width! || breakpoint < height! | |||
|
|
|||
| export const allowedFormats: Array<AttachmentOptions['forceFormat']> = [ | |||
| export type AllowedFormats = 'jpeg' | 'png' | 'webp' | 'avif' | 'tiff' | 'gif' | 'svg' | 'svg+xml' | |||
There was a problem hiding this comment.
Rename union type to single: AllowedFormat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows gif and svg to be uploaded without being converted by sharp for breakpoints and thumbnails.
I'm running this on several projects with no problems.