Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loot total bug #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix loot total bug #60

wants to merge 2 commits into from

Conversation

Seraphli
Copy link

GetItemCount already gets the total number.

@nebularg
Copy link
Owner

nebularg commented Nov 10, 2019

The problem is the chat event used to show the item count often (usually) fires before the item count updates. So to make it more consistent I'd have to delay the GetItemCount call, but Parrot can't really do async notices.

@Seraphli
Copy link
Author

Seraphli commented Nov 12, 2019

Yeah, after I change the code, I found out that too. I saw someone include a timer in their code and wait for 0.2 seconds before calling the function. Maybe you could try this way.
https://github.com/hurricup/WoW-Ace3/blob/master/AceTimer-3.0/AceTimer-3.0.lua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants