TASK: always wrap div #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves neos#139
|
Thanks for the Pull Request, we already have a solution in the Neos.UI itself. Guess we don't need the change here. So we just need to wait for the 8.3.11 release of the Neos.UI :) |
|
Good news, thanks for the info 👍 |
|
The release has been published, but thanks for the PR anyway 💙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no interface for forcing new tags when using the HtmlAugmenter (implicitely called via wrapContentObject) so this quick change solves the problem of divs not getting nested as described in issue #139.