!!! FEATURE: Separate properties and references in clientEval #3813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIX: Remove unneeded reference properties Co-authored-by: Marc Henry Schultz <85400359+mhsdesign@users.noreply.github.com>
pKallert
changed the title
mhsdesign
changed the title
|
Looks good sofar but ill have to try this out ;) It seems that with the transientValues we still mix properties and references but that seems sensible ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As discussed in neos/neos-development-collection#5156 references should be available separately in ClientEval
How I did it
I adjusted the logic for loading data for the right sidebar to be separated into properties and references.
depends on #3810
How to verify it
Use ClientEval:console.log(node) in the right to see that references are no longer in the properties array but now their separate item:
