Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Remove required flag from showResetButton prop on selectbox #3848

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Sep 9, 2024

The prop is actually not required in its implementation and the UI tends to throw warnings because of the required flag.

The prop is actually not required and the UI tends to throw warnings because of the required flag.
@github-actions github-actions bot added Bug Label to mark the change as bugfix 8.3 labels Sep 9, 2024
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const {showResetButton} = this.props;
        if (showResetButton) {

is safe indeed.

Thanks ❤️

@mhsdesign mhsdesign merged commit a8edb2d into 8.3 Sep 9, 2024
11 checks passed
@mhsdesign mhsdesign deleted the bugfix/proptypes-warning-showresetbutton branch September 9, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants