Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle nx-run targets that don't have an executor #5201

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

lukasholzer
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Handle nx:run-command executors by falling back to the package based detection. THis is only a cosmetic change to ignore those bugsnag reporting:
https://app.bugsnag.com/netlify/build-info/errors/64b917b0ecafad000866418d?event_id=64ba7fc300beb910f08e0000


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested review from a team as code owners July 21, 2023 12:57
@lukasholzer lukasholzer self-assigned this Jul 21, 2023
@lukasholzer lukasholzer enabled auto-merge (squash) August 24, 2023 09:14
@lukasholzer lukasholzer merged commit 5a1acfa into main Aug 25, 2023
30 checks passed
@lukasholzer lukasholzer deleted the fix/handle-nx-run-targets branch August 25, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants