Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add method for an inline merge of the netlify config #5369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

estephinson
Copy link
Contributor

@estephinson estephinson commented Nov 7, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

Allow in-process merging of configuration without persisting the changes to disk.

Related to CT-151, CT-71, CT-72


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@estephinson estephinson requested review from a team as code owners November 7, 2023 12:13
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

Comment on lines +13 to +15
// Performs a merge of the configuration changes with the existing `netlify.toml`,
// and returns the updated configuration
export const mergeConfig = async function (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Performs a merge of the configuration changes with the existing `netlify.toml`,
// and returns the updated configuration
export const mergeConfig = async function (
/**
* Performs a merge of the configuration changes with the existing `netlify.toml`,
* and returns the updated configuration
*/
export const mergeConfig = async function (

Use JSDoc for function annotations as they can be picked up by the intellisense

@github-actions github-actions bot added the stale label Jan 6, 2024
@github-actions github-actions bot removed the stale label Jul 26, 2024
@github-actions github-actions bot added the stale label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants