feat: Frameworks API cleanup #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
changed the title
|
This pull request adds or modifies JavaScript ( |
eduardoboucas
commented
Jun 25, 2024
| export const preCleanup: CoreStep = { | ||
| event: 'onPreBuild', | ||
| coreStep, | ||
| coreStepId: 'pre_cleanup', | ||
| coreStepName: 'Pre cleanup', | ||
| coreStepDescription: () => 'Cleaning up leftover files from previous builds', | ||
| condition: blobsPresent, |
There was a problem hiding this comment.
This means that this core step will now run for all builds as opposed to only running if there are blobs directories. That is fine, since calling rm() on a directory that doesn't exist will not throw here, and we have a try/catch around the calls anyway.
lukasholzer
approved these changes
Jun 25, 2024
| const files = await new fdir() | ||
| .withRelativePaths() // we want the relative path from the blobsDir | ||
| .filter((fpath) => !path.basename(fpath).startsWith(METADATA_PREFIX)) | ||
| .crawl(blobsDir) | ||
| .withPromise() | ||
|
|
||
| files.forEach((filePath) => { | ||
| return files.map((filePath) => { |
This was referenced Jun 25, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5668 with some clean-up tasks:
deploy_configdirectories toframeworks_api.netlify/v1directory before building to ensure we're not using leftover artefacts from a previous buildforEachwith amap