Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename .mts to .ts #6179

Merged
merged 26 commits into from
Nov 21, 2023
Merged

refactor: rename .mts to .ts #6179

merged 26 commits into from
Nov 21, 2023

Conversation

ericapisani
Copy link
Contributor

Summary

Using the .mjs extension is no longer needed now that we've completed the transition to ESM. Having these file extensions is redundant since we have type:module in the package.json.

This change updates files that were previously .mts to .ts, which means that the compiled files will be .js. As a result, import lines needed to be updated as well.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Copy link

github-actions bot commented Nov 16, 2023

📊 Benchmark results

Comparing with e5c33a0

  • Dependency count: 1,396 (no change)
  • Package size: 404 MB ⬇️ 0.00% decrease vs. e5c33a0
  • Number of ts-expect-error directives: 0 ⬇️ Infinity% decrease vs. e5c33a0

@ericapisani ericapisani marked this pull request as ready for review November 16, 2023 18:05
@ericapisani ericapisani requested review from a team as code owners November 16, 2023 18:05
CHANGELOG.md Outdated Show resolved Hide resolved
site/src/_ui.mjs Outdated Show resolved Hide resolved
@ericapisani ericapisani added the automerge Add to Kodiak auto merge queue label Nov 21, 2023
@kodiakhq kodiakhq bot merged commit 5eb2133 into main Nov 21, 2023
35 checks passed
@kodiakhq kodiakhq bot deleted the ep/ct-296-convert-tojs branch November 21, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants