-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: load command's actions async to improve performance #6180
Merged
Merged
Changes from 55 commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
95cc3cd
feat: convert addon-auth
sarahetter 8602912
feat: convert addons:config
sarahetter 0c7d81b
feat: convert addons:create
sarahetter 9ecf1c3
feat: convert addons:delete
sarahetter 4f6d088
feat: convert addons:list
sarahetter a5ff286
feat: convert api
sarahetter ac00447
feat: types
sarahetter b0eed4b
feat: convert build, and types
sarahetter 86e8016
feat: convert blobs:delelte
sarahetter 4dc736c
feat: convert blobs:get
sarahetter 3aa9002
feat: convert blobs:list
sarahetter 263d107
feat: convert blobs:set
sarahetter 197f996
feat: remove import
sarahetter 3819fe5
feat: convert completion
sarahetter 0f83440
feat: convert deploy
sarahetter e56e4c0
feat: convert dev
sarahetter 24b05e2
feat: convert env:get
sarahetter 443e21f
feat: convert env:import
sarahetter d54ad4b
feat: convert env:list
sarahetter 068f730
feat: convert env:set
sarahetter 079e097
feat: convert env:unset
sarahetter 81c0e28
feat: convert env:clone
sarahetter bd351d4
feat: convert functions:build
sarahetter c3c0140
feat: convert functions:create
sarahetter 21db904
feat: convert functions:invoke
sarahetter 8363827
feat: convert functions:list
sarahetter 3896e25
feat: convert functions: serve
sarahetter bbad02c
feat: convert init
sarahetter 36ca6a8
chore: format
sarahetter 3519b19
feat: convert integration
sarahetter 8b9c32f
feat: convert link
sarahetter fe01541
feat: convert lm:info
sarahetter 7c4258a
feat: convert lm:install
sarahetter b1f8e34
feat: convert lm:setup
sarahetter 03f6033
feat: convert lm:uninstall
sarahetter 9730c7d
feat: convert login
sarahetter 1786651
feat: convert logout
sarahetter 7d02439
feat: convert logs:deploy
sarahetter 29788c5
feat: convert logs:functions
sarahetter 0d5d00e
feat: convert open
sarahetter 33e0dfc
feat: convert recipes
sarahetter 998df3d
feat: convert serve
sarahetter 95ecbb7
feat: convert sites:create
sarahetter fee8cbb
feat: convert sites:create-template
sarahetter 653de4b
feat: convert sites:list
sarahetter b47bf77
feat: convert sites:delete
sarahetter 2934bca
feat: convert status
sarahetter 1f17237
feat: convert switch
sarahetter 5b09944
feat: convert unlink
sarahetter 91b4cdb
feat: convert watch
sarahetter 3062f12
test: fix test for sites:create-template
sarahetter b725a60
test: fix tests for logs:
sarahetter aef5612
test: sites:create
sarahetter be1b204
test: loogs
sarahetter 8a50759
test: integration
sarahetter fac8ecc
Merge branch 'main' into sarahetter/ct-276-improve-performance
sarahetter ca739d5
chore: prettier
sarahetter a9dbed4
chore: up timeout for start dev server in test utils
sarahetter 6fd7917
chore: return to original value
sarahetter d655ea1
chore: try await execa
sarahetter a4c7e2e
feat: nope, not that
sarahetter 02285d2
Merge branch 'main' into sarahetter/ct-276-improve-performance
sarahetter bcca563
Merge branch 'main' into sarahetter/ct-276-improve-performance
sarahetter 3f10923
chore: merge conflict stuff
sarahetter 5669348
chore: package lock from main
sarahetter a712bf9
chore: merge conflict stuff
sarahetter 4854f86
test: fix test import
sarahetter c811a49
test: fix wrong import
sarahetter 33fe45c
chore: revert dev because dev server tests are timing out, moving to β¦
sarahetter 8a11d17
chore: missing things
sarahetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,20 @@ | ||
export { createApiCommand } from './api.mjs' | ||
import { chalk } from '../../utils/command-helpers.mjs' | ||
import BaseCommand from "../base-command.mjs"; | ||
|
||
export const createApiCommand = (program: BaseCommand) => | ||
program | ||
.command('api') | ||
.argument('[apiMethod]', 'Open API method to run') | ||
.description( | ||
`Run any Netlify API method | ||
For more information on available methods checkout https://open-api.netlify.com/ or run '${chalk.grey( | ||
'netlify api --list', | ||
)}'`, | ||
) | ||
.option('-d, --data <data>', 'Data to use') | ||
.option('--list', 'List out available API methods', false) | ||
.addExamples(['netlify api --list', `netlify api getSite --data '{ "site_id": "123456" }'`]) | ||
.action(async (apiMethod, options, command) => { | ||
const { apiCommand } = await import('./api.mjs') | ||
await apiCommand(apiMethod, options, command ) | ||
} ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation looks a bit off here. I don't think we've changed the Prettier settings to run on
.mts
files?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah @ericapisani is this in the plans with what you're doing now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to add the new extensions here:
cli/package.json
Line 79 in 7ab484b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added config in #6187, and ran format. Should be prettier now :D