Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release-please): remove package-name to avoid prefixed releases #43

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

netr0m
Copy link
Owner

@netr0m netr0m commented Jul 1, 2024

Description

Run goreleaser on tag created by release-please, as release-please cannot trigger other workflow (i.e. on-tag-created.yaml) due to limitations with GH Actions

  • Resolves # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have read the contribution guidelines
  • My changes follow the Styleguide of this project
  • I have run the pre-commit hooks included in this repository
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • All GitHub Actions workflows for this branch/PR have run successfully

@netr0m netr0m added the cicd CI/CD label Jul 1, 2024
@netr0m netr0m self-assigned this Jul 1, 2024
@netr0m netr0m force-pushed the ci/goreleaser-on-release-please-tagged branch from 22d2da7 to a5f5334 Compare July 1, 2024 10:39
@netr0m netr0m merged commit 88aeea5 into main Jul 1, 2024
9 checks passed
@netr0m netr0m deleted the ci/goreleaser-on-release-please-tagged branch July 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant