Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCC Glitch Mosfet Control Update #444

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

DJShepherd
Copy link
Contributor

  • Refactored VCC glitch mosfet control
  • Refactored default and glitch setup/disable API
  • Added message utilities; Added optimized data copy
  • Added API utilities

Passed tests/api_test.py, validated glitch_hp/lp value assignment and readback.

@DJShepherd
Copy link
Contributor Author

DJShepherd commented Jun 7, 2023

A big chunk of changes in ChipWhispererExtra.py is because I moved CWExtraSettings above GPIOSettings so I could access the CWExtraSettings class globals from GPIOSettings globals.

I would test the CWLITE VCC glitch demos but I think a long time ago, I burned out my mosfets cuz I can't hit glitches anymore :( I bought some replacement mosfets, but I have to find time to do the soldering work on the board.

I do have a HUSKY, but I haven't had time to set it up. I do plan on playing around with it soon and use that as my new testing/development platform.

@DJShepherd DJShepherd force-pushed the DJShepherd/fast_glitcht branch 3 times, most recently from 1e2b700 to 707ea7c Compare June 10, 2023 07:53
@DJShepherd
Copy link
Contributor Author

DJShepherd commented Jun 10, 2023

To see more of the direction I'm proposing for the CONSTS/API interface that I created in this PR, I'm currently working on the same interface for the TIO/GPIO API as seen here:
Compare: DJShepherd/fast_glitcht...DJShepherd/gpio_api_update

@DJShepherd DJShepherd force-pushed the DJShepherd/fast_glitcht branch 5 times, most recently from c4d7112 to 991fb73 Compare June 15, 2023 07:39
@DJShepherd
Copy link
Contributor Author

Any progress on getting this validated and merged in? I've been keeping it updated and making sure nothing breaks in terms of the workflow I have been testing with.

@alex-dewar
Copy link
Contributor

Sorry about the delays with this. I've been working on stuff related to an upcoming training, so I don't want to make too many big changes before that.

@DJShepherd
Copy link
Contributor Author

Sorry about the delays with this. I've been working on stuff related to an upcoming training, so I don't want to make too many big changes before that.

Understandable, thanks for the update, was just curious! :) I'll just keep working on the other changes slowly, I've been busy as of late, too.

self.clock.reset_dcms()
if count > 10:
raise OSError("Could not lock PLL. Try rerunning this function or calling scope.pll.reset(): {}".format(self))
if not self.clock.try_wait_clkgen_locked(10):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a Husky version as well (cwhardware/ChipWhispererHuskyClock.py)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is common logic so for now, in order to not duplicate/copy-paste code, I just moved it to be an OpenADC method with a note to move it into a base/common clock class if refactoring ever happens.

@@ -452,6 +553,9 @@ def lo_gain_errors_disabled(self):
else:
return False

def disable_clip_and_lo_gain_errors(self, disabled):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in scope.errors instead of scope.adc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, this is just in the wrong class in this file (needs to be in TriggerSettings)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@alex-dewar
Copy link
Contributor

Will run this on a few more scope/target setups, but should be good once the fixes above are implemented

@DJShepherd
Copy link
Contributor Author

I've been a bit busy so I haven't gotten to it, but it's on my radar and I'm hoping to tackle it this weekend!

…etup/disable API; Added message utilities; Added optimized data copy; Added API utilities and tests
@alex-dewar
Copy link
Contributor

Can confirm the latest update works. Will merge in now.

@alex-dewar alex-dewar merged commit dc2a9a2 into newaetech:develop Sep 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants