Skip to content

Commit

Permalink
address PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kang-makes committed Sep 17, 2024
1 parent bb350a8 commit f11ce5a
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 9 deletions.
2 changes: 1 addition & 1 deletion charts/super-agent/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ As of the creation of the chart, it has no particularities and this section can
| super-agent-deployment.config.auth.secret.private_key.plain_pem | string | `nil` | In case `.config.auth.secret.create` is true, you can set these keys to set private key directly as plain text. This options is mutually exclusive with `base64_pem`. |
| super-agent-deployment.config.auth.secret.private_key.secret_key | string | `private_key` | Key inside the secret containing the private key. |
| super-agent-deployment.config.opamp.enabled | bool | `true` | Enables or disables the auth against fleet control. It implies to disable any fleet communication and running the agent in stand alone mode where only the agents specified on `.config.subAgents` will be launched. |
| super-agent-deployment.config.subAgents | string | {} (Empty. That defaults to configure the `newrelic/io.opentelemetry.collector` subagent) | Values that the fleet is going to have in the deployment. |
| super-agent-deployment.config.subAgents | string | `newrelic/io.opentelemetry.collector` (See `values.yaml`) | Values that the fleet is going to have in the deployment. If empty, chart will automatically add `newrelic/io.opentelemetry.collector` subagent. On the other hand, if populated the list of agent created is the one specified overwriting the default. |
| super-agent-deployment.config.superAgent | object | See `values.yaml` | Configuration for the Super Agent. |
| super-agent-deployment.config.superAgent.content | object | `{}` | It you are a PowerUser, you can use this to override the configuration that has been created automatically by the chart. This configuration here will be **MERGED** with the configuration specified above. If you need to have you own configuration, disabled the creation of this configMap and create your own. |
| super-agent-deployment.config.superAgent.create | bool | `true` | Set if the configMap is going to be created by this chart or the user will provide its own. |
Expand Down
22 changes: 14 additions & 8 deletions charts/super-agent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,25 @@ super-agent-deployment:
# If you need to have you own configuration, disabled the creation of this configMap and create your own.
content: {}

# -- Values that the fleet is going to have in the deployment.
# @default -- {} (Empty. That defaults to configure the `newrelic/io.opentelemetry.collector` subagent)
# -- Values that the fleet is going to have in the deployment. If empty, chart will automatically add `newrelic/io.opentelemetry.collector` subagent.
# On the other hand, if populated the list of agent created is the one specified overwriting the default.
# @default -- `newrelic/io.opentelemetry.collector` (See `values.yaml`)
subAgents:
# The values of the fleet depends on the deployment itself. Each subagent has a different set of variables so you have to go to the subagent documentation
# find the configuration needed for the subagent.
#
# The example below, open-telemetry, is enabled by default if no subagent is set up.
# open-telemetry:
# type: newrelic/io.opentelemetry.collector:0.2.0
# content:
# chart_version: "0.4.0"
# chart_values:
# # you can set here modifications to the open telemetry chart
# open-telemetry:
# type: newrelic/io.opentelemetry.collector:0.2.0
# content:
# chart_values:
# global:
# licenseKey: ${nr-env:NR_LICENSE_KEY}
# cluster: ${nr-env:NR_CLUSTER_NAME}
# nrStaging: ${nr-env:NR_STAGING}
# verboseLog: ${nr-env:NR_VERBOSE}
# region: ${nr-env:NR_REGION}
# # you can set here modifications to the open telemetry chart

opamp:
# -- Enables or disables the auth against fleet control. It implies to disable any fleet communication and running the agent
Expand Down

0 comments on commit f11ce5a

Please sign in to comment.