[nr-k8s-otel-collector] Honor the LowDataMode toogle from the common-library #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon-library-lowdatamode
csongnr
approved these changes
Oct 1, 2024
dbudziwojskiNR
requested changes
Oct 2, 2024
| @@ -153,5 +153,5 @@ receivers: | |||
| enabled: true | |||
|
|
|||
| # -- (bool) Send only the [metrics required](https://github.com/newrelic/helm-charts/tree/master/charts/nr-k8s-otel-collector/docs/metrics-lowDataMode.md) to light up the NR kubernetes UI, this agent defaults to setting lowDataMode true, but if this setting is unset, lowDataMode will be set to false | |||
There was a problem hiding this comment.
After this change, wouldn't lowDataMode be true if unset? If so, we should update this wording.
There was a problem hiding this comment.
@kang-makes Bumping this :) Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
The value for
lowDataModewas hard coded at values level so a user cannot set the value if you not go deep down to the chart and patch it.This change has its own implementation of the lowDataMode helper that defaults to
truewhile honoring the behaviour of the common-library of setting a value agloballevel.Which issue this PR fixes
Special notes for your reviewer:
Checklist
[mychartname])