Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facerecognition: change to FACE_MODEL=3 and adjust memory values #4742

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented May 31, 2024

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels May 31, 2024
@szaimen szaimen added this to the next milestone May 31, 2024
@szaimen
Copy link
Collaborator Author

szaimen commented May 31, 2024

@matiasdelellis can we also lower the limit in

and
"php /var/www/html/occ face:setup -M 4G",
then?

Or does it need to stay as high due to

"php /var/www/html/occ config:app:set facerecognition analysis_image_area --value 4320000",
?

@matiasdelellis
Copy link
Collaborator

"nextcloud_memory_limit=4096M"

The absolute minimum is 512 MB that you have to set to allow it to work. but if the user has a lot of images (50 thousand?) they will probably need more memory to perform the face clustering step, therefore we must leave a reasonable value to start.

I will try to evaluate but maybe 2GB could be something very reasonable value.

"php /var/www/html/occ face:setup -M 4G",

1G, it is a mere formality but we must assign it.

"php /var/www/html/occ config:app:set facerecognition analysis_image_area --value 4320000",

It's a lot, but it will work without problems.

@matiasdelellis
Copy link
Collaborator

p.s: You can also increase the memory only for the commands and leave the default configuration.

php -d memory_limit=2048M

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Collaborator Author

szaimen commented May 31, 2024

all right, adjusted :)

@szaimen szaimen changed the title facerecognition: change to FACE_MODEL=3 facerecognition: change to FACE_MODEL=3 and adjust memory values May 31, 2024
@szaimen szaimen merged commit 59da067 into main Jun 6, 2024
4 checks passed
@szaimen szaimen deleted the enh/noid/facerecognition-model branch June 6, 2024 08:26
@szaimen
Copy link
Collaborator Author

szaimen commented Jun 7, 2024

This is now released with v9.0.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants