Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aio-interface: improve constructor #5389

Merged
merged 1 commit into from
Oct 7, 2024
Merged

aio-interface: improve constructor #5389

merged 1 commit into from
Oct 7, 2024

Conversation

docjyJ
Copy link
Collaborator

@docjyJ docjyJ commented Oct 7, 2024

Hi,
Step by step, this PR concerns constructors.

Many files are concerned, but only constructors are modified, it should not be a problem for merges.

No class definition changes!

Reference :

This PR is part of #5368

Take care

Signed-off-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
@docjyJ docjyJ added 3. to review Waiting for reviews enhancement New feature or request labels Oct 7, 2024
@docjyJ docjyJ added this to the next milestone Oct 7, 2024
@docjyJ docjyJ requested a review from szaimen October 7, 2024 08:40
@docjyJ docjyJ self-assigned this Oct 7, 2024
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@st3iny st3iny changed the title Inprouve constructor Inprove constructor Oct 7, 2024
@szaimen szaimen merged commit a54cfed into main Oct 7, 2024
6 checks passed
@szaimen szaimen deleted the enh/noid/constructor branch October 7, 2024 10:49
@szaimen szaimen changed the title Inprove constructor php code: improve constructor Oct 7, 2024
@szaimen szaimen changed the title php code: improve constructor aio-interface: improve constructor Oct 7, 2024
@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2024

This is now released with v9.7.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants