Refactor manual-install Compose.yml: Simplify Environment Variables #5459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed explicit values for environment variables in `docker-compose.yml`. - Utilized default values for better flexibility and maintainability. - Updated network configuration to use the default bridge driver. Note: Using `network: default` is sufficient within Docker Compose; there's no need to create a separate `nextcloud-network` for all hosts. 🚀 Signed-off-by: lll <2844835+flll@users.noreply.github.com>
Co-authored-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com> Signed-off-by: lll <2844835+flll@users.noreply.github.com>
Co-authored-by: Jean-Yves <7360784+docjyJ@users.noreply.github.com> Signed-off-by: lll <2844835+flll@users.noreply.github.com>
`update-yaml.sh`の処理の追加を - .services[].networks の削除 - =%%を削除する特殊な処理 これにより、 すべてのサービスをdefaultのネットワークに接続させることができ、 変数の簡略化が見込めます Signed-off-by: lll <2844835+flll@users.noreply.github.com>
Signed-off-by: lll <2844835+flll@users.noreply.github.com> Co-Authored-By: Jean-Yves <7360784+docjyJ@users.noreply.github.com>
szaimen
changed the title
szaimen
commented
Oct 22, 2024
nextcloud-aio-helm-chart/templates/nextcloud-aio-nextcloud-deployment.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: lll <2844835+flll@users.noreply.github.com>
flll
approved these changes
Oct 22, 2024
|
@flll the script update-helm.sh is currently producing this output: https://github.com/nextcloud/all-in-one/pull/5458/files. It does not look right and needs to be adjusted. |
|
I'm sorry, I made a mistake in my operations. |
|
All good, no problem! :) I've restored the change. Now you can go can follow the instructions from #5393 (comment) |
szaimen
commented
Oct 22, 2024
nextcloud-aio-helm-chart/templates/nextcloud-aio-nextcloud-deployment.yaml
Outdated
Show resolved
Hide resolved
|
There is this PR now where you can check the changes that you are doing to this this pr (5459) |
- [update-yaml.sh] Change sed command option from -e to -E
- [update-helm.sh] Add check for docker image tag as first argument, exit 2 if missing
- [update-helm.sh] Modify snap command to run with sudo
- [update-helm.sh] Add new sed commands:
- [sed] Convert `- AB_CD_EFG` to `- AB_CD_EFG=${AB_CD_EFG}`
- [sed] Apply conversion only to uppercase variables
- [sed] Exclude NET_RAW, SYS_NICE, NET_ADMIN, and MKNOD capabilities from conversion
This reverts commit 57d03d8.
szaimen
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local copy of #5393