Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added teams to invite placeholder #6130

Merged

Conversation

niclasheinz
Copy link
Contributor

It is now also possible to add teams (former Cirlcles) to an event as participants. Unfortunately, it is not visible in the placeholder that this is possible. This is the reason, why I made this PR.

Signed-off-by: Niclas Heinz 160846201+niclasheinz@users.noreply.github.com

Signed-off-by: Niclas Heinz <160846201+niclasheinz@users.noreply.github.com>
@niclasheinz niclasheinz marked this pull request as ready for review July 9, 2024 11:43
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 23.97%. Comparing base (1917636) to head (ffccb86).
Report is 5 commits behind head on main.

Files Patch % Lines
.../components/Editor/Invitees/InviteesListSearch.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6130   +/-   ##
=========================================
  Coverage     23.97%   23.97%           
  Complexity      457      457           
=========================================
  Files           247      247           
  Lines         11606    11606           
  Branches       2188     2178   -10     
=========================================
  Hits           2782     2782           
  Misses         8509     8509           
  Partials        315      315           
Flag Coverage Δ
javascript 15.46% <0.00%> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niclasheinz
Copy link
Contributor Author

What are the next steps to implement those changes to production?

@miaulalala miaulalala merged commit 7e436be into nextcloud:main Jul 23, 2024
31 of 32 checks passed
@miaulalala
Copy link
Contributor

/backport to stable4.7

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Jul 23, 2024
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Jul 23, 2024
@miaulalala
Copy link
Contributor

What are the next steps to implement those changes to production?

merged, thanks for your contribution!

@miaulalala miaulalala added this to the v5.0.0 milestone Jul 23, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants