Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce header sizes in calendar modal #6192

Merged
merged 1 commit into from
Jul 23, 2024
Merged

feat: reduce header sizes in calendar modal #6192

merged 1 commit into from
Jul 23, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 23, 2024

Resolves #6154

Before After
grafik grafik

@st3iny st3iny added 3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request labels Jul 23, 2024
@st3iny st3iny added this to the v5.0.0 milestone Jul 23, 2024
@st3iny st3iny self-assigned this Jul 23, 2024
@st3iny st3iny force-pushed the feat/calendar-modal-header-size branch from 308c951 to c5069b2 Compare July 23, 2024 12:22
@st3iny st3iny changed the title fix: reduce header sizes in calendar modal feat: reduce header sizes in calendar modal Jul 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.93%. Comparing base (d57fb02) to head (3bd39a1).
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/AppNavigation/EditCalendarModal.vue 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #6192   +/-   ##
=========================================
  Coverage     23.93%   23.93%           
  Complexity      457      457           
=========================================
  Files           247      247           
  Lines         11627    11627           
  Branches       2184     2195   +11     
=========================================
  Hits           2783     2783           
+ Misses         8528     8527    -1     
- Partials        316      317    +1
Flag Coverage Δ
javascript 15.44% <0.00%> (ø)
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny
feat: reduce header sizes in calendar modal
3bd39a1 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the feat/calendar-modal-header-size branch from c5069b2 to 3bd39a1 Compare July 23, 2024 12:32
@st3iny st3iny enabled auto-merge July 23, 2024 12:35
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 23, 2024
@st3iny st3iny merged commit c0c49de into main Jul 23, 2024
27 of 28 checks passed
@st3iny st3iny deleted the feat/calendar-modal-header-size branch July 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@GretaD GretaD Awaiting requested review from GretaD

@hamza221 hamza221 Awaiting requested review from hamza221

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@st3iny st3iny

Labels
4. to release Ready to be released and/or waiting for tests to finish design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

Calendar edit modal should use NcDialog instead of NcModal
2 participants
@st3iny @miaulalala