-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(attachmentService, propfindErrorParse): add an error message for when a file is not compatible for windows #6303
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6303 +/- ##
============================================
- Coverage 23.75% 23.73% -0.03%
Complexity 454 454
============================================
Files 246 247 +1
Lines 11718 11731 +13
Branches 2220 2223 +3
============================================
Hits 2784 2784
- Misses 8615 8627 +12
- Partials 319 320 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feat, not enh 😉
This is a fix 🙊 This needs a backport too |
…when a file is not compatible for windows Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
1826bfd
to
d7288b0
Compare
/backport to stable5.0 |
Does this need a backport to stable4.7 as well? |
No because nextcloud/server#44963 is for 30+ |
|
||
return messageElement?.textContent | ||
} catch (parseError) { | ||
console.error(t('spreed', 'Error while parsing a PROPFIND error'), parseError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be sourced from calendar
instead of spreed
.
Fix #6245
Mostly copied from https://github.com/nextcloud/spreed/blob/main/src/utils/propfindErrorParse.ts