-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow adding self to shared event #6418
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6418 +/- ##
============================================
- Coverage 23.56% 23.55% -0.01%
Complexity 454 454
============================================
Files 247 247
Lines 11693 11696 +3
Branches 2205 2206 +1
============================================
Hits 2755 2755
- Misses 8618 8621 +3
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaks the attendees tab on new events: TypeError: Cannot read properties of null (reading 'uri')
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pleas squash and we are good to go.
Do we want to backport this (since the issue is from 2020)? Or is this too risky because of the recent shared calendar changes in server? |
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
005b7be
to
479ba82
Compare
Resolves: #2659
Modified alreadyInvitedEmails result to NOT exclude the current user by default and to only include actual organize and attendees.