Fix loading and activity warning

Signed-off-by: Julius Härtl <jus@bitgrid.net>
nextcloud · Nov 10, 2018 · a569078 · a569078
1 parent 24db3fb
commit a569078
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/lib/Activity/DeckProvider.php b/lib/Activity/DeckProvider.php
@@ -142,7 +142,11 @@ protected function setSubjects(IEvent $event, $subject, array $parameters) {
 		$placeholders = $replacements = [];
 		foreach ($parameters as $placeholder => $parameter) {
 			$placeholders[] = '{' . $placeholder . '}';
-			$replacements[] = $parameter['name'];
+			if (array_key_exists('name', $parameter)) {
+				$replacements[] = $parameter['name'];
+			} else {
+				$replacements[] = '';
+			}
 		}
 
 		$event->setParsedSubject(str_replace($placeholders, $replacements, $subject))

diff --git a/lib/Service/BoardService.php b/lib/Service/BoardService.php
@@ -88,7 +88,7 @@ public function __construct(
 	/**
 	 * @return array
 	 */
-	public function findAll($since = 0) {
+	public function findAll($since = -1) {
 		$userInfo = $this->getBoardPrerequisites();
 		$userBoards = $this->boardMapper->findAllByUser($userInfo['user'], null, null, $since);
 		$groupBoards = $this->boardMapper->findAllByGroups($userInfo['user'], $userInfo['groups'],null, null,  $since);

diff --git a/lib/Service/StackService.php b/lib/Service/StackService.php
@@ -127,7 +127,7 @@ public function find($stackId) {
 	 * @throws \OCA\Deck\NoPermissionException
 	 * @throws BadRequestException
 	 */
-	public function findAll($boardId, $since = 0) {
+	public function findAll($boardId, $since = -1) {
 		if (is_numeric($boardId) === false) {
 			throw new BadRequestException('boardId must be a number');
 		}