Deck card comment notification label improvement

[Jerome-Herbinet]

Concerning the following wording, which doesn't mention Deck, so we don't know what's the concerned app.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required

[cypress]

Passing run #1332 ↗︎

0

17

0

0

0

Details:

Merge 8e4c783 into b9316cd...
Project: Deck	Commit: fc9d212bc9 ℹ️
Status: Passed	Duration: 01:38 💡
Started: Aug 22, 2023 6:27 AM	Ended: Aug 22, 2023 6:29 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[jancborchardt]

Seems good! Btw @Jerome-Herbinet since there are 3 settings related to Deck, it would make sense to group them together as a proper group outside of "Other activities" if Deck is enabled, right?

[Jerome-Herbinet]

Seems good! Btw @Jerome-Herbinet since there are 3 settings related to Deck, it would make sense to group them together as a proper group outside of "Other activities" if Deck is enabled, right?

You are right @jancborchardt and I thought about it but, to he honest, I don't know how to create a new category ... and how long and/or complex the development would be 🤔

[jancborchardt]

Maybe @nickvergessen can you point @Jerome-Herbinet in the right direction? :)

[nickvergessen]

Make the base class extend OCP\Activity\ActivitySettings and then set the group identifier and name like in:

https://github.com/nextcloud/server/blob/215aef3cbdc1963be1bb6bca5218ee0a4b7f1665/apps/dav/lib/CalDAV/Activity/Setting/CalDAVSetting.php#L43-L49

[juliusknorr]

Thanks for the pull request, I took over and pushed some adjustments to group the settings: