Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] fix: Split query to fetch board ids to avoid slow query join #4963

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[stable25] fix: Split query to fetch board ids to avoid slow query join #4963

merged 1 commit into from
Jul 31, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 28, 2023 •
edited
Loading

Backport of #4906

@juliusknorr
fix: Split query to fetch board ids to avoid slow query join
db4cf92 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr changed the title [stable25] [stable26] fix: Split query to fetch board ids to avoid slow query join [stable25] fix: Split query to fetch board ids to avoid slow query join Jul 28, 2023
@cypress
Copy link

cypress bot commented Jul 28, 2023

Passing run #1178 ↗︎

0 6 0 0 Flakiness 0

Details:

Merge db4cf92 into 1fc1683...
Project: Deck Commit: 2aad57dd38 ℹ️
Status: Passed Duration: 02:17 💡
Started: Jul 28, 2023 8:51 AM Ended: Jul 28, 2023 8:53 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

GretaD
GretaD approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test it

@GretaD
Copy link
Contributor

GretaD commented Jul 31, 2023

is this good enough to merge?

@juliusknorr
Copy link
Member Author

Yes, CI failure is unrelated and I'll address that separately for the stable25 branch to adapt to the new CI workers.

@juliusknorr juliusknorr merged commit b80524b into stable25 Jul 31, 2023
18 of 24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/4950/stable25 branch July 31, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GretaD GretaD GretaD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @GretaD