Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next cloud deck table scrolling #5377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adshrest
Copy link

Description:
Currently, when a table is created within a Deck card description, and the table width exceeds the display-box width, users have to use a touchpad to scroll horizontally. This can be inconvenient, as there are no visible horizontal scrollbars indicating additional columns.

Proposal:
I suggest implementing a horizontal scrollbar for tables within the Deck card description. This can be achieved with a simple CSS tweak, such as adding overflow-x: scroll; to the relevant style.

Comment on lines +11 to +15
/* Add horizontal scrollbar for tables in card descriptions */
.card-description table {
width: 100%; /* Ensure the table takes 100% width of the container */
overflow-x: auto; /* Enable horizontal scrolling */
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this duplicate rule over here, best would be to only adjust this in the component that renders the table which would be here:

<div v-if="textAppAvailable" class="description__text">

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the scoping might limit the css rule so you probably need something like

.description__text:deep(table) {

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I left a comment inline about where to best apply this change.

Please also make sure that your commits have a sign-off message and best squash the changes into one commit once done.

@juliusknorr
Copy link
Member

Hi @adshrest Would you still be up for addressing the comments? Let me know if there are any questions.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants