Fix stuttering and freezing of client while computing sync state changes (macOS VFS) #7397
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant to check if it is reachable Only check every 60 seconds, this way we do not freeze the client for 3 seconds every time that we want to check the reachability while the extension is unreachable Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Any longer does not really yield any positive result and freezes the client for longer Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
/backport to stable-3.14 |
|
AppImage file: nextcloud-PR-7397-568243100dc9d1f4b583ec98056dd73737ac6748-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time we compute the overall sync state we check if the File Provider Extension is reachable so we can display if this has encountered a problem. The issue is that if it is not reachable, we wait 3 seconds to receive a reply, and if we do not, we wait all of those 3 seconds. Now have that happen every single time we need to compute the sync state.
This PR addresses the problem by slashing the wait time down to 1 second and adding a reachability check timeout of 300 seconds, so we will (worst case) encounter a 1 second freeze every 5 minutes instead