Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.13] Change defaults of promptDeleteFiles to false #7409

Open
wants to merge 2 commits into
base: stable-3.13
Choose a base branch
from
+4 −1
Open

[stable-3.13] Change defaults of promptDeleteFiles to false #7409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
412369b
Set promptDeleteFiles default to false.
camilasan Oct 24, 2024
c1deb13
On upgrade notification for mass file deletion is disabled by default.
camilasan Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/gui/application.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ bool Application::configVersionMigration()
configFile.setLaunchOnSystemStartup(configFile.launchOnSystemStartup());
Utility::setLaunchOnStartup(theme->appName(), theme->appNameGUI(), configFile.launchOnSystemStartup());

// default is now off to displaying dialog warning user of too many files deletion
configFile.setPromptDeleteFiles(false);

// back up all old config files
QStringList backupFilesList;
QDir configDir(configFile.configPath());
Expand Down
2 changes: 1 addition & 1 deletion src/libsync/configfile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* for more details.
*/

#include "config.h"

Check failure on line 15 in src/libsync/configfile.cpp

View workflow job for this annotation

GitHub Actions / build

src/libsync/configfile.cpp:15:10 [clang-diagnostic-error] 

'config.h' file not found

#include "configfile.h"
#include "theme.h"
Expand Down Expand Up @@ -1020,7 +1020,7 @@
bool ConfigFile::promptDeleteFiles() const
{
QSettings settings(configFile(), QSettings::IniFormat);
return settings.value(QLatin1String(promptDeleteC), true).toBool();
return settings.value(QLatin1String(promptDeleteC), false).toBool();
}

void ConfigFile::setPromptDeleteFiles(bool promptDeleteFiles)
Expand Down
Loading