-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the duplicate extension "js" warning from the NGINX configuration #10408
Conversation
Hi @susnux, I've rebased the latest Kind regards, |
the rebase went wrong unfortunately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I fixed the rebase (you accidentally merged the master branch in resulted in duplicated commits)
@acataluddi but before we can merge this you need to sign you commit. (pull and |
Hi @susnux, done. Kind regards, |
@nickvergessen you accidentally dropped the sign-off |
I used the Github button "Update branch". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ok that this removes the warning.
Hi @acataluddi - seems the signoff was dropped. Can you please checkout your branch, do a pull, rebase on current master and do git commit --amend -s? |
Hi Anna, I've signed off all the commits and pushed the branch for a second review. Kind regards, |
…tion. Fixed #1 Signed-off-by: Adriano Cataluddi <acataluddi@gmail.com>
The current NGINX configuration triggers the following warning