Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bz2 from recommend extensions #11444

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Jan 15, 2024

☑️ Resolves

Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@J0WI
Copy link
Contributor Author

J0WI commented Jan 15, 2024

/backport to stable28

Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
@come-nc
Copy link
Contributor

come-nc commented Jan 22, 2024

The problem here is that from what I understood bz2 is documented to be a supported format for applications.
So we should deprecate/forbid it before removing it from recommended modules.

Does the appstore really support bz2? If not that means we can safely remove it without deprecation period I think.
If it does support it, can we get statistics on whether it’s actually used?

@nickvergessen
Copy link
Member

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into it I think the appstore does not support bz2 and it is not used, so let’s go with this.

@bigcat88
Copy link
Member

Currently we have no applications in the AppStore in bz2 format and afaik it is not possible currently to upload in such format.

@come-nc come-nc merged commit ce34184 into nextcloud:master Jan 22, 2024
11 checks passed
@come-nc
Copy link
Contributor

come-nc commented Jan 22, 2024

/backport to stable28

Copy link

backportbot bot commented Jan 22, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/11444/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2c6ac0e1dd56f3d0044226377d5b51998e80fa01 72c438aab1bacab206d7811ccd109547c1977f5f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/11444/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/11444/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@J0WI J0WI deleted the rm-bz2-recommend branch January 23, 2024 23:53
Copy link
Contributor

github-actions bot commented May 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants