fix ACL rename bug

Signed-off-by: Jake Esser <jake@jakes-co.de> Replaced delete permission check with parent comparison Use strict comparison Fixed formatting issue Signed-off-by: Jake Esser <jake@jakes-co.de> Formatted code
nextcloud · Mar 7, 2024 · 6f8b431 · 6f8b431
1 parent b58cde4
commit 6f8b431
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/lib/ACL/ACLStorageWrapper.php b/lib/ACL/ACLStorageWrapper.php
@@ -94,7 +94,12 @@ public function rename($source, $target) {
 		if ($sourceParent === '.') {
 			$sourceParent = '';
 		}
-		return $this->checkPermissions($sourceParent, Constants::PERMISSION_DELETE) &&
+		$targetParent = dirname($target);
+		if ($targetParent === '.') {
+			$targetParent = '';
+		}
+		return  ($sourceParent === $targetParent ||
+			$this->checkPermissions($sourceParent, Constants::PERMISSION_DELETE)) &&
 			$this->checkPermissions($source, Constants::PERMISSION_UPDATE & Constants::PERMISSION_READ) &&
 			$this->checkPermissions($target, $permissions) &&
 			parent::rename($source, $target);