Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp and rollback of versions #2117

Closed
wants to merge 2 commits into from
Closed

Fix timestamp and rollback of versions #2117

wants to merge 2 commits into from

Conversation

XueSheng-GIT
Copy link

@XueSheng-GIT XueSheng-GIT commented Oct 11, 2022

Fix #2055 and fix #2077

File versioning for groupfolders is still broken. I'm not a programmer but after some investigation this change does improve things. This is my first pull request, thus I'm not sure whether this is the right way to go. Feel free to guide me into the right direction! Thanks.

@XueSheng-GIT
Copy link
Author

@juliushaertl @ArtificialOwl Any hints how to proceed with this? This is my first pull and I'm a bit lost what else I have to do. Thanks for your support.

@solracsf

This comment was marked as resolved.

@solracsf

This comment was marked as resolved.

@XueSheng-GIT
Copy link
Author

@solracsf thanks for your hints! Commits should have been squashed now and DCO seems to be successful now.
Anything else I can do to get this merged?

@XueSheng-GIT XueSheng-GIT marked this pull request as ready for review May 1, 2023 11:15
@solracsf solracsf added the 3. to review Items that need to be reviewed label May 1, 2023
@solracsf solracsf requested a review from CarlSchwan May 1, 2023 16:05
@solracsf
Copy link
Member

solracsf commented May 1, 2023

Marked for review, wait for CI to complete, fix any errors (if any) and wait for it to be reviewd and merged :)

@XueSheng-GIT
Copy link
Author

Coding standards check failed because $version->getRevisionId() is no int? But actually it is!?

@solracsf
Copy link
Member

solracsf commented May 9, 2023

What about:

$targetMount->getStorage()->touch($targetInternalPath, intval($version->getRevisionId()));

By wrapping $version->getRevisionId() with intval(), you ensure that the second argument passed to touch() is an integer. This should resolve the InvalidScalarArgument error.

Fix #2055 and #2077

Signed-off-by: Michael Frase <Michael.Frase@gmx.de>
Signed-off-by: Michael Frase <Michael.Frase@gmx.de>
@XueSheng-GIT
Copy link
Author

Closing this pull in favour of #2543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollback of versions breaks version history Wrong timestamp of file versions
2 participants