Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat custom propagator #2533

Closed
wants to merge 3 commits into from
Closed

Feat custom propagator #2533

wants to merge 3 commits into from

Conversation

tacruc
Copy link

@tacruc tacruc commented Aug 31, 2023

Cherry-picked from #2440 and targeted to master.
Thanks @gbrousse-recia for development.

Description

A custom Propagator to fix files updates propagation in nested groupfolders.
Based on branch stable25.
Tested on Nextcloud 25.0.6.
Related Issue

maybe #652 and #1787
Motivation and Context

We had synchronization issues between the server and the client when the files were in nested groupfolders. After some research, we noticed that the propagation was not done correctly (groupfolders etags unchanged in the filecache table).

Signed-off-by: gbrousse-recia <gregory.brousse@recia.fr>
Signed-off-by: gbrousse-recia <gregory.brousse@recia.fr>
@tacruc tacruc changed the title Feat propagator Feat custom propagator Aug 31, 2023
Signed-off-by: Arne Hamann <git@arne.email>
@tacruc tacruc added the 3. to review Items that need to be reviewed label Aug 31, 2023
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@icewind1991
Copy link
Member

There shouldn't be a need to propagate changes to parent groupfolders, cross-storage etag/mtime propagation is handled by it's own system. For folders containing other storages, the returned etag is calculated based on the stored etag for that folder and the root-etags for any storage inside the folder.

@blizzz blizzz mentioned this pull request Nov 22, 2023
@skjnldsv
Copy link
Member

Last comment by code owner stayed unanswered.
Closing :)

If you will decide to work on this feature again and if it hasn't been fixed or implemented already, feel free to re-open and solve the various conflicts.

Thanks for the interest in Nextcloud and the effort put into this! 🙇

@skjnldsv skjnldsv closed this Aug 28, 2024
@skjnldsv skjnldsv deleted the feat_propagator branch August 28, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants