Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the app version to the capabilities endpoint #2861

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

ThibautPlg
Copy link
Contributor

Minor update on the lib/Appinfo/Capabilities.php to expose the appVersion of groupfolders in the result of a ocs/v2.php/cloud/capabilities web request.
This is useful when managing multiple Nextcloud to monitor and report the app version. Many other Nextcloud Apps are already exposing this data (circles, richdocuments, deck to name a few)

Request JSON output before:

        "groupfolders": {
          "hasGroupFolders": true
        },

Request JSON output after:

        "groupfolders": {
          "appVersion": "16.0.4",
          "hasGroupFolders": true
        },

Best regards,

@Jerome-Herbinet Jerome-Herbinet added 3. to review Items that need to be reviewed feature: api Items related to the (OCS) API labels Mar 25, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ThibautPlg
Copy link
Contributor Author

Hello
Is something awaiting a modification from my side? I don't see the error on the php-cs pipeline.

Regards,

@skjnldsv
Copy link
Member

Is something awaiting a modification from my side? I don't see the error on the php-cs pipeline.

Fixed it for you :)

@skjnldsv skjnldsv added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
ThibautPlg and others added 2 commits August 28, 2024 14:08
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit a111fe5 into nextcloud:master Aug 28, 2024
37 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Items that are ready for releasing feature: api Items related to the (OCS) API feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants