Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ACLManager tests #3043

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix: ACLManager tests #3043

merged 1 commit into from
Jul 9, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jul 6, 2024 •
edited
Loading

Broken after 777bbe4
Cypress fix at #3044

@solracsf solracsf added the 3. to review Items that need to be reviewed label Jul 6, 2024
@solracsf @artonge
fix: ACLManager tests
7603ea2 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

chore: optimize code

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: call logger

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Add LoggerInterface

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Fix: Typo

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@artonge
Copy link
Contributor

artonge commented Jul 8, 2024

Rebased

@solracsf solracsf merged commit 360b947 into master Jul 9, 2024
40 of 42 checks passed
@solracsf solracsf deleted the fixACLManagerTests branch July 9, 2024 16:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This was referenced Aug 29, 2024
Merged
Merged
@solracsf solracsf mentioned this pull request Aug 30, 2024
Merged
@skjnldsv
Copy link
Member

/backport to backport/2813/stable28

@backportbot backportbot bot mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solracsf @artonge @skjnldsv @come-nc