fix: include mountpoint in original location for trash items #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
From #3339 we have https://github.com/x7airworker/groupfolders/blob/361d4314f6fa53a1a90735bf4fd42e30fb5d3785/tests/Trash/TrashBackendTest.php#L218 which can produce this error reliably. Can you add it and verify it fixes the test? |
|
This (should) only changes how the path is displayed. So I think it's orthogonal from that issue/test, which I understand to be caused by what path is stored. |
|
You're right, I confused this with another issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the "original location" for deleted groupfolder items don't show the path of the groupfolder itself. Making it harder for users to know what the deleted file is.
This changes it to store the "full" original location and separately keep the "interal" original location for the restore operation.