-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iMip Request Handling #10116
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@@ -135,7 +135,11 @@ public function process(): void { | |||
$sender = $imapMessage->getFrom()->first()->getEmail(); | |||
$recipient = $account->getEmail(); | |||
foreach ($imapMessage->scheduling as $schedulingInfo) { // an IMAP message could contain more than one iMIP object | |||
if ($schedulingInfo['method'] === 'REPLY') { | |||
if ($schedulingInfo['method'] === 'REQUEST') { | |||
$processed = $this->calendarManager->handleIMipRequest($principalUri, $sender, $recipient, $schedulingInfo['contents']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Psalm says. Open the code in PHPStorm. It will help you see that the interface is lacking the method.
Ref nextcloud/server#47826 (review).
The app works with 30 and 31. Only 31 has the new API -> needs a method_exists check and a fallback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see that the interface is lacking the method.
Correct me if I am wrong but is this not expected since the server PR that the mail app needs is NOT merged yet? The handleIMipRequest is a new method that I added to the server (see required PR link in description) and is NOT merged yet.
The app works with 30 and 31. Only 31 has the new API -> needs a method_exists check and a fallback
Okay, i was going to ask if we are going to back port this, but this answers my question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of the backport you can have deployments of Mail on older versions of Nextcloud where the method doesn't exist. So your code has to expect the method to be missing and have a workaround.
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Summary
Checklist