Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button preference and functionality to open sidebar #1304

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

David-Development
Copy link
Member

@David-Development David-Development commented Oct 28, 2023

Closes #1288

Superseding #1299

mentalinc and others added 4 commits October 21, 2023 06:09
This is to add a preference to restore the behaviour of the app before this commit:
28ea07e

Signed-off-by: mentalinc <mentalinc@outlook.com>
The back button now works as it prior to the change, there is a setting to configure if you want the back button to open the feeds list or to just exit (default)

Signed-off-by: mentalinc <mentalinc@outlook.com>
Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development
Copy link
Member Author

@mentalinc Sorry for the duplicate MR - thanks for your initial work! I thought I could merge this MR into yours but I can only select branches under this namespace.

I've ran some more tests and found that if the "Back buttons opens drawer" feature is disabled I have to swipe back twice (because the enabled flag had to be set to false first). I refactored it a little and I think I found a good solution. Let me know if that works for you too!

Signed-off-by: David Luhmer <david-dev@live.de>
Signed-off-by: David Luhmer <david-dev@live.de>
Signed-off-by: David Luhmer <david-dev@live.de>
@David-Development David-Development merged commit 24f8dbb into master Oct 31, 2023
15 of 16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the back-press branch October 31, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Back button now exits instead of returns to feed list
2 participants