Merge pull request #40264 from nextcloud/backport/40234/stable23

[stable23] enh: skip processing for empty response
nextcloud · Sep 5, 2023 · 5648713 · 5648713
2 parents 5fce5e3 + 6ddf1b7
commit 5648713
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/private/Http/Client/DnsPinMiddleware.php b/lib/private/Http/Client/DnsPinMiddleware.php
@@ -25,6 +25,7 @@
  */
 namespace OC\Http\Client;
 
+use OCP\Http\Client\LocalServerException;
 use Psr\Http\Message\RequestInterface;
 
 class DnsPinMiddleware {
@@ -127,6 +128,10 @@ public function addDnsPinning() {
 
 				$targetIps = $this->dnsResolve(idn_to_utf8($hostName, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46), 0);
 
+				if (empty($targetIps)) {
+					throw new LocalServerException('No DNS record found for ' . $hostName);
+				}
+
 				$curlResolves = [];
 
 				foreach ($ports as $port) {