Merge pull request #33230 from nextcloud/enh/noid/64bit-setup-check-link

add a link to system requirements for new 64bit setup check
nextcloud · Jul 13, 2022 · 6d2952d · 6d2952d
2 parents 9dbcf05 + c1b88f9
commit 6d2952d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js
@@ -425,7 +425,9 @@
 						messages.push({
 							msg: t(
 								'core',
-								'It seems like you are running a 32bit PHP version. Nextcloud needs 64bit to run well. Please upgrade your OS and PHP to 64bit!'
+								'It seems like you are running a 32bit PHP version. Nextcloud needs 64bit to run well. Please upgrade your OS and PHP to 64bit! For further details read {linkstart}the documentation page about this ↗{linkend}.'
+								.replace('{linkstart}', '<a target="_blank" rel="noreferrer noopener" class="external" href="' + OC.theme.docPlaceholderUrl.replace('PLACEHOLDER', 'admin-system-requirements') + '">')
+								.replace('{linkend}', '</a>'),
 							),
 							type: OC.SetupChecks.MESSAGE_TYPE_WARNING
 						})

diff --git a/core/js/tests/specs/setupchecksSpec.js b/core/js/tests/specs/setupchecksSpec.js
@@ -1403,7 +1403,7 @@ describe('OC.SetupChecks tests', function() {
 
 			async.done(function( data, s, x ){
 				expect(data).toEqual([{
-					msg: 'It seems like you are running a 32bit PHP version. Nextcloud needs 64bit to run well. Please upgrade your OS and PHP to 64bit!',
+					msg: 'It seems like you are running a 32bit PHP version. Nextcloud needs 64bit to run well. Please upgrade your OS and PHP to 64bit! For further details read <a href="https://docs.example.org/admin-system-requirements" class="external" rel="noreferrer noopener">the documentation page about this ↗</a>.',
 					type: OC.SetupChecks.MESSAGE_TYPE_WARNING
 				}]);
 				done();