Skip to content

Commit

Permalink
Merge pull request #40481 from nextcloud/fix/guest-pages-contentinfo
Browse files Browse the repository at this point in the history
fix: content info footer on guest pages
  • Loading branch information
st3iny authored Sep 19, 2023
2 parents ec72121 + 9a5a392 commit 7cf8421
Show file tree
Hide file tree
Showing 7 changed files with 20 additions and 35 deletions.
2 changes: 1 addition & 1 deletion core/css/guest.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/css/guest.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 13 additions & 2 deletions core/css/guest.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* Copyright (c) 2011, Jan-Christoph Borchardt, http://jancborchardt.net
* SPDX-FileCopyrightText: 2022 Carl Schwan <carl@carlschwan.eu>
* SPDX-FileCopyrightText: Richard Steinmetz <richard@steinmetz.cloud>
This file is licensed under the Affero General Public License version 3 or later.
See the COPYING-README file. */

Expand Down Expand Up @@ -735,11 +736,19 @@ img.icon-loading-small-dark, object.icon-loading-small-dark, video.icon-loading-

/* FOOTER */
footer {
min-height: 70px;
margin-top: auto;
.info .entity-name {
font-weight: bold;
}

&[role="contentinfo"] {
padding: 6px 24px;
margin-bottom: 1rem;

.info {
margin: 0;
}
}
}

/* keep the labels for screen readers but hide them since we use placeholders */
Expand Down Expand Up @@ -795,11 +804,13 @@ a.legal {

.guest-box, .body-login-container {
color: var(--color-main-text);
background-color: var(--color-main-background);
background-color: var(--color-main-background-blur);
padding: $guest-container-padding;
border-radius: var(--border-radius-rounded);
box-shadow: 0 0 10px var(--color-box-shadow);
display: inline-block;
-webkit-backdrop-filter: var(--filter-background-blur);
backdrop-filter: var(--filter-background-blur);
}

.guest-box {
Expand Down
28 changes: 1 addition & 27 deletions core/src/views/Login.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
-
- @author 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
- @author Richard Steinmetz <richard@steinmetz.cloud>
-
- @license GNU AGPL version 3 or any later version
-
Expand Down Expand Up @@ -209,33 +210,6 @@ body {
}
}
// Same look like a dashboard panel
.login-box.guest-box, footer {
color: var(--color-main-text);
background-color: var(--color-main-background-blur);
-webkit-backdrop-filter: var(--filter-background-blur);
backdrop-filter: var(--filter-background-blur);
}
footer {
// Usually the same size as the login box, but allow longer texts
min-width: 320px;
box-sizing: border-box;
// align with login box
box-shadow: 0 0 10px var(--color-box-shadow);
// set border to pill style and adjust padding for it
border-radius: var(--border-radius-pill);
padding: 6px 24px;
// always show above bottom
margin-bottom: 1rem;
min-height: unset;
// reset margin to reduce height of pill
p.info {
margin: auto 0px;
}
}
.fade-enter-active, .fade-leave-active {
transition: opacity .3s;
}
Expand Down
2 changes: 1 addition & 1 deletion core/templates/layout.guest.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
</main>
</div>
</div>
<footer role="contentinfo">
<footer role="contentinfo" class="guest-box">
<p class="info">
<?php print_unescaped($theme->getLongFooter()); ?>
</p>
Expand Down
4 changes: 2 additions & 2 deletions dist/core-login.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-login.js.map

Large diffs are not rendered by default.

0 comments on commit 7cf8421

Please sign in to comment.