Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mimetype): Fix aborted transaction on PostgreSQL when storing mimetype #40203

Merged
merged 2 commits into from
Sep 16, 2023
Merged

fix(mimetype): Fix aborted transaction on PostgreSQL when storing mimetype #40203

merged 2 commits into from
Sep 16, 2023

Commits on Sep 1, 2023

  1. fix(mimetype): Remove unnecessary transaction when storing a mime type 

    Fixes nextcloud#40064.

This could be fixed by adding a rollback and starting a new transaction
before the SELECT query, but in this case that would have the same
effect as not using one.
See https://dev.mysql.com/doc/refman/8.0/en/innodb-autocommit-commit-rollback.html
and https://www.postgresql.org/docs/7.1/sql-begin.html#R1-SQL-BEGIN-1

Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
    @lhsazevedo
    lhsazevedo committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    5de021c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Wrap mimetype insert and getLastInsertId in a transaction 

    Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
    @lhsazevedo
    lhsazevedo committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    c587f68 View commit details
    Browse the repository at this point in the history