-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): add folder icon overlay #40209
Conversation
I don't have an e2ee setup available, can you try it yourself @artonge ? 🙏 |
199987e
to
eda00a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good design-wise!
It would be nice to switch the share-triangle to this less technical "add person" icon:
https://pictogrammers.com/library/mdi/icon/account-plus/
I think I mentioned to you before @skjnldsv? But probably separate issue as it should be done across the board – your pick.
We did that for the Navigation yes |
eda00a0
to
421e4c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes the key looks good to me 👍 |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
421e4c1
to
b304c37
Compare
Yup key for encrypted folder and lock for locked folder is good! @tobiasKaminsky this probably needs to be reflected on the mobile clients as well? |
I created an issue for us, so that we an update all folder icons (e.g. this "unsplash" thing is also new to me). |
Yep, icons are changing more and more along the releases. |
Once we start, we will ask/check for a complete list, so that all clients have same as web. |
@skjnldsv Where can I get the exact same icons as in your screenshot? |
|
Ref #39914
I decided to hardcode it for now as I couldn't find a good API way to tackle that.
We can always talk and improve from there :)
@nextcloud/designers if you want to adjust those icons, suggest new ones from the material design set as a review comment. I currently used the ones we already use or some that got asked by Jan.