-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OC namespace for core ReponseDefinitions instead of OCA #45509
Use OC namespace for core ReponseDefinitions instead of OCA #45509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this!
/backport to stable29 |
/backport to stable28 |
352a2a1
to
f1952e1
Compare
Your commit should probably start with |
f1952e1
to
5ba2d6d
Compare
@JulienFS please fix the CI (code checkers and lint php-cs) |
5ba2d6d
to
7fe4569
Compare
Performance and cypress don't seem to pass. At first sight I don't know what to do. Should I try to fix them or is it somehow out of my hands ? |
No those are flaky sometimes. I just gotta restart cypress until it works (and performance is not required to pass) |
435f778
to
4f5e651
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The CI on this PR seems to be really unlucky 😞 |
4f5e651
to
e3d1d8c
Compare
Signed-off-by: Julien CHATY-CAPELLE <julien@chaty-capelle.fr>
e3d1d8c
to
2d84d0f
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45509/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45509/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
1 similar comment
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/45509/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2d84d0f5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45509/stable29 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
It looks like #36666 and #39331 lead to having a core file in the
OCA
namespace. To my understanding,OCA
is for apps, whileOC\Core
is for core.TODO
Checklist