fix(federation): Do not overwrite certificate bundle #47340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
a team,
Altahrim and
yemkareems
and removed request for
a team
nickvergessen
approved these changes
Aug 20, 2024
juliusknorr
force-pushed
the
fix/federation-certificate-store
branch
from
499c495
to
00b3bc4
Compare
|
Added some more cases that I noticed when trying to debug something with @Antreesy where the request failed silently to also make use of the setting and log errors in apps/files_sharing/lib/External/Storage.php |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
fix/federation-certificate-store
branch
from
00b3bc4
to
232c22f
Compare
provokateurin
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julius Härtl jus@bitgrid.net
Summary
One might still want to verify self-signed certificates and not disable verification entirely. Before this change the
verifyoption was always overwritten with true which means that the system certificate store was used instead of the Nextcloud built in one. We should only pass verify if we actually intent to disable verification, else the http client is injecting the cert bundle properly inserver/lib/private/Http/Client/Client.php
Line 55 in dae7c15
Checklist