Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use empty template by default when pressing enter #47363

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Aug 20, 2024

Summary

Previously, when pressing enter without clicking on anything in the template picker, it would simply close and nothing would happen -- no document created, etc. The expected behavior is that pressing enter would just create a document based on the default, empty template. This PR makes it so that the empty template preview is focused when the picker is opened, thus pressing enter when the picker opens will now create a file based on the empty template.

2024-08-20.17-30-17.mp4

Checklist

@elzody elzody added bug 3. to review Waiting for reviews javascript labels Aug 20, 2024
@elzody elzody requested a review from susnux August 20, 2024 21:44
@elzody elzody self-assigned this Aug 20, 2024
@elzody elzody requested a review from skjnldsv as a code owner August 20, 2024 21:44
@AndyScherzinger AndyScherzinger added this to the Nextcloud 31 milestone Aug 20, 2024
@AndyScherzinger
Copy link
Member

/backport to stable30

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@elzody elzody force-pushed the fix/template-picker-press-enter branch 3 times, most recently from b44cd1b to 3ee622d Compare August 21, 2024 16:17
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 21, 2024
elzody and others added 3 commits August 21, 2024 15:00
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
@elzody elzody force-pushed the fix/template-picker-press-enter branch from 6396b0d to 82c6b92 Compare August 21, 2024 19:02
@skjnldsv skjnldsv merged commit 003bf4b into master Aug 21, 2024
113 checks passed
@skjnldsv skjnldsv deleted the fix/template-picker-press-enter branch August 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new file > choose template: enter key closes dialogue instead of opening new document
6 participants