Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trusted server icon recovery without addressbook change #47415

Merged

Conversation

pabzm
Copy link
Contributor

@pabzm pabzm commented Aug 22, 2024

Summary

Always set server status to OK after successful runs

Previously if a server status got set to failure, it stayed that way
until an addressbook-sync found changes. Now the server status is set to
OK after each successful sync check (if that's not the case already),
regardless of addressbook changes.

Additionally a log warning was added in two places where the server status gets set to failure when a job gets removed due to being too old. This would've helped in debugging a problem, so now there's a logging hint for next time.

Checklist

@pabzm
Copy link
Contributor Author

pabzm commented Aug 22, 2024

This is my first PR in this repo, I'm a little unsure about some details (e.g. those checkboxes). Please let me know if there's something I should change or do.

@pabzm pabzm force-pushed the Fix/trusted-server-icon-recovery-without-addressbook-change branch 2 times, most recently from 44ada5f to 28b6c95 Compare August 22, 2024 09:16
@ChristophWurst
Copy link
Member

/backport to stable30

@ChristophWurst
Copy link
Member

/backport to stable29

@ChristophWurst
Copy link
Member

/backport to stable28

@pabzm pabzm force-pushed the Fix/trusted-server-icon-recovery-without-addressbook-change branch from 957c9fb to da46741 Compare August 22, 2024 13:58
Previously if a server status got set to failure, it stayed that way
until an addressbook-sync found changes. Now the server status is set to
OK after each successful sync check (if that's not the case already),
regardless of addressbook changes.

This change also includes two new logging statements, which could help
next time someone debugs this.

Signed-off-by: Pablo Zimdahl <pablo@nextcloud.com>
@pabzm pabzm force-pushed the Fix/trusted-server-icon-recovery-without-addressbook-change branch from da46741 to 3c3667f Compare August 22, 2024 14:02
@miaulalala miaulalala merged commit 1b39abb into master Aug 22, 2024
171 checks passed
@miaulalala miaulalala deleted the Fix/trusted-server-icon-recovery-without-addressbook-change branch August 22, 2024 15:01
Copy link

welcome bot commented Aug 22, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants