-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Adjust margin at the file list bottom #47467
Conversation
This was also more visually appealing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, as @skjnldsv mentioned, the bottom spacing is intentional, so that:
- It is obvious you reached the end and it’s not loading anymore
- The last items and summary are nicely readable in the center of the screen and not stuck at the bottom
(Some other apps like some text editors do this similarly.)
I thought exactly the opposite, as scrolling into a blank page looks like something needs to load there 😅 But if this was a design decision, then maybe at least adjust the number to not be hard coded pixels but something variable like |
But this is not a text editor. Cursed words incoming: "What's the competition doing?". I don't think this is expected from a file list, or any list in general, no? |
Sounds good @susnux! :) @artonge it looks better, and some times inbetween the space was also missing and it resulted in it looking off. It’s just weird when the last files and the summary is stuck to the bottom of the screen. |
I can understand both (personally I also tend to say a list that overflows one page should only be scroll able to the bottom), but also the design decision to have the margin seems reasonable, so I will adjust the PR to be relative to screen size. (Because whats worse is e.g. VS code where you can scroll a whole page below the last line of code 🙈 ) |
5ba28f3
to
71de671
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! :)
Instead make it relative to screen size. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
71de671
to
e840ec2
Compare
/backport to stable30 |
/backport to stable29 |
Summary
IIRC this was added when the drop notice was placed on the bottom, but the notice is now always set on the top. So this just causes weird whitespace on the files list.
Screenshots (scrolled fully down)
Checklist