perf(ObjectStoreStorage): Improve (slow) move on same object bucket

[cfiehe]

Summary

This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with #46013. However, after upload there are still some unnecessary put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

Needs some tests to verify the behavior and prevent regressions.

[cfiehe]

Looks good to me. Changes committed :-).

[provokateurin]

Tests are still missing though.

[cfiehe]

Tests are still missing though.

I hope, that the object store tests from https://github.com/nextcloud/server/tree/master/tests/lib/Files/ObjectStore will give us a hint, if this change causes harm.

[provokateurin]

Sure there shouldn't be any regressions from this change, but we also need a test that ensures the new behavior is present. So please add a test that moves a file on an object storage and ensures this case is triggered.

[provokateurin]

Awesome! This is a really good improvement 💙

[provokateurin]

You need to follow the conventional commit format, so the commit message should be something like fix(ObjectStoreStorage): Remove unnecessary move on same bucket.

[cfiehe]

You need to follow the conventional commit format, so the commit message should be something like fix(ObjectStoreStorage): Remove unnecessary move on same bucket.

Oh yes. Sorry, I'm still practicing 😅.

[provokateurin]

No problem, we are here to help :) I just realized though that I made a mistake myself and ideally it would be perf(...): ... to indicate that it improves performance. You don't need to change it though, just something to keep in mind for the future.

[cfiehe]

It seems that pull requests from a fork are not supported. Should I close this one here and create a new one based on https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html?

[provokateurin]

No I think it's fine for this since it only changes backend stuff and your change is covered by tests.

[provokateurin]

@sorbaugh can you merge?

[provokateurin]

@cfiehe please don't rebase, it is not necessary unless there actually are conflicts.

[cfiehe]

@cfiehe please don't rebase, it is not necessary unless there actually are conflicts.

Oh, sorry.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[sorbaugh]

aaand merged! Thanks @cfiehe for your contribution!! <3

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)